[codex] Use model metadata for skills usage instructions#29740
Merged
Conversation
9aa1d70 to
d2f2ffc
Compare
dylan-hurd-oai
approved these changes
Jun 24, 2026
dylan-hurd-oai
left a comment
Collaborator
There was a problem hiding this comment.
1 comment, lgtm otherwise
| impl From<AvailableSkills> for AvailableSkillsInstructions { | ||
| fn from(available_skills: AvailableSkills) -> Self { | ||
| pub fn from_available_skills( | ||
| mut available_skills: AvailableSkills, |
Collaborator
There was a problem hiding this comment.
I'd personally prefer immutability over the memory savings here
Contributor
Author
There was a problem hiding this comment.
Changed to immutable:
pub fn from_available_skills(
available_skills: &AvailableSkills,
include_skills_usage_instructions: bool,
)
Collaborator
|
Unblocking, but one thing to consider: |
xl-openai
approved these changes
Jun 28, 2026
d2f2ffc to
7d4af15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
include_skills_usage_instructionsmodel metadata fieldgpt-5.5model metadata