Skip to content

ci: fail jobs that dirty the worktree - #29720

Merged
bolinfest merged 8 commits into
mainfrom
codex/clean-worktree-check
Jun 24, 2026
Merged

ci: fail jobs that dirty the worktree#29720
bolinfest merged 8 commits into
mainfrom
codex/clean-worktree-check

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Why

CI jobs should not silently leave tracked changes or untracked files in the repository worktree.

What

  • Add a shared final worktree-cleanliness action to 19 checkout-bearing PR and main CI jobs.
  • Ignore the intentional SDK scratch directory and nested V8 checkout.
  • Pin Bazelisk in shared CI setup so .bazelversion remains authoritative, avoiding MODULE.bazel.lock deltas on Windows runners.
  • Leave rust-ci-full and release-only workflows unchanged.
  • Update AGENTS.md to discourage review bots from asking for MODULE.bazel.lock changes.

@anp-oai
anp-oai marked this pull request as ready for review June 23, 2026 21:17
@anp-oai

anp-oai commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: af0f9eb8b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@bolinfest
bolinfest self-requested a review June 24, 2026 18:05
@bolinfest
bolinfest merged commit 93c7904 into main Jun 24, 2026
46 checks passed
@bolinfest
bolinfest deleted the codex/clean-worktree-check branch June 24, 2026 18:06
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants