[codex] surface rollout budget exhaustion - #29715
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8a90dbabd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #[ts(export_to = "v2/")] | ||
| pub enum CodexErrorInfo { | ||
| ContextWindowExceeded, | ||
| RolloutBudgetExceeded, |
There was a problem hiding this comment.
Adding RolloutBudgetExceeded changes the v2 app-server wire enum, but the checked-in generated artifacts still omit the new rolloutBudgetExceeded value (for example, codex-rs/app-server-protocol/schema/typescript/v2/CodexErrorInfo.ts:12, and the JSON schemas do not contain it). Clients generated from these fixtures will still reject or fail to classify the new error this change is meant to expose, so please run just write-app-server-schema and update the app-server docs list of common codexErrorInfo values with the new variant.
AGENTS.md reference: AGENTS.md:L288-L293
Useful? React with 👍 / 👎.
| #[serde(rename_all = "snake_case")] | ||
| pub enum CodexErrKind { | ||
| TurnAborted, | ||
| RolloutBudgetExceeded, |
There was a problem hiding this comment.
oh sorry - just saw this, replacing with follow up PR
There was a problem hiding this comment.
I'd personally vote for RolloutBudgetExceeded instead since session is a bit of an overloaded term in the harness already
Summary
CodexErr::RolloutBudgetExceededinstead of a generic interrupted turnCodexErrorInfoand app-server v2codexErrorInfopathThis gives app-server clients a stable
rolloutBudgetExceedederror they can classify without guessing fromstatus="interrupted".Tests
just test -p codex-core rollout_budget