test: branch on target OS instead of runner flavor - #29712
Merged
Conversation
anp-oai
force-pushed
the
codex/target-os-test-interface
branch
from
June 23, 2026 20:50
fec51ab to
c4d565c
Compare
anp-oai
marked this pull request as ready for review
June 23, 2026 21:02
Contributor
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4d565c418
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pakrym-oai
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Core tests should branch on the executor's operating system, not on runner details such as Docker or Wine. This keeps platform behavior stable as new test backends are added and reserves Wine-specific skips for actual runner debt.
What
TestTargetOsand target/host-aware skip helpers while keepingTestEnvironmentinternal.Validation
just test -p core_test_supportjust test -p codex-core remote_test_env_can_connect_and_use_filesystembazel test //codex-rs/core:core-all-wine-exec-test --test_output=errorsreached test execution; unrelated existing view-image, path, and timing failures remain.just test -p codex-coreandjust testreached broad test execution; this checkout has unrelated helper, sandbox, and timing failures.