Let image generation extension hosts control output persistence - #29711
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 543e0eb580
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fbe68a32ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Why
Some extension hosts need generated images returned without writing them to the local filesystem or giving the model a local path.
What changed
tl;dr: we now conduct all extension operations in the image gen extension
saved_pathinstead of persisting extension images again in core.Validation
just test -p codex-image-generation-extensionjust test -p codex-app-server standalone_image_generation_returns_saved_path_hint_to_modeljust test -p codex-core extension_tool_uses_granted_turn_permissions_without_local_persistencejust test -p codex-core tools::handlers::extension_tools::tests