Skip to content

Let image generation extension hosts control output persistence - #29711

Merged
won-openai merged 5 commits into
mainfrom
img_basic
Jun 24, 2026
Merged

Let image generation extension hosts control output persistence#29711
won-openai merged 5 commits into
mainfrom
img_basic

Conversation

@won-openai

@won-openai won-openai commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Why

Some extension hosts need generated images returned without writing them to the local filesystem or giving the model a local path.

What changed

tl;dr: we now conduct all extension operations in the image gen extension

  • Let hosts provide an optional image save root when installing the extension.
  • Save images and return path hints only when a save root is configured.
  • Return image data without saving or adding a path hint when no save root is configured.
  • Preserve the extension-provided saved_path instead of persisting extension images again in core.
  • Leave built-in image generation unchanged.

Validation

  • just test -p codex-image-generation-extension
  • just test -p codex-app-server standalone_image_generation_returns_saved_path_hint_to_model
  • just test -p codex-core extension_tool_uses_granted_turn_permissions_without_local_persistence
  • just test -p codex-core tools::handlers::extension_tools::tests
  • tested on CODEX CLI on both save_root: CODEX_HOME and None
  • tested on CODEX APP on both as well

@won-openai
won-openai requested a review from a team as a code owner June 23, 2026 20:33

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 543e0eb580

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/app-server/src/extensions.rs Outdated
Comment thread codex-rs/ext/image-generation/Cargo.toml

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fbe68a32ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/tests/suite/extension_sandbox.rs
@won-openai won-openai changed the title Move standalone image persistence into the extension Let image generation extension hosts control output persistence Jun 23, 2026
@won-openai
won-openai merged commit 61f5a84 into main Jun 24, 2026
46 of 47 checks passed
@won-openai
won-openai deleted the img_basic branch June 24, 2026 01:51
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants