[codex] Handle additional tools in rollout persistence metrics - #29672
Merged
Conversation
anp-oai
approved these changes
Jun 23, 2026
rka-oai
enabled auto-merge (squash)
June 23, 2026 18:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle
ResponseItem::AdditionalToolsin rollout persistence metrics.The persistence metrics match was added after the
AdditionalToolsvariant and omitted it, causing release builds to fail with a non-exhaustive pattern error. This assigns the item theresponse.additional_toolsmetrics label.Release failure: https://github.com/openai/codex/actions/runs/28043786727/job/83016608475
Validation
just fmtjust test -p codex-rollout(76 passed)