Handle additional tools in rollout persistence metrics - #29669
Merged
winston-openai merged 1 commit intoJun 23, 2026
Conversation
rasmusrygaard
marked this pull request as ready for review
June 23, 2026 17:38
rasmusrygaard
approved these changes
Jun 23, 2026
winston-openai
deleted the
dev/winston/fix-rollout-additional-tools-metric
branch
June 23, 2026 18:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The rollout persistence metrics added on current
mainexhaustively matchResponseItem, but omitResponseItem::AdditionalTools. That preventscodex-rolloutand downstream targets from compiling across Cargo and Bazel builds.What
Map
ResponseItem::AdditionalToolsto theresponse.additional_toolsmetric label, consistent with the existing exact-variant labels.Validation
just test -p codex-rollout(76 passed)just fix -p codex-rollout