core: pin yielded code cells to their request runtime - #29606
Closed
sayan-oai wants to merge 1 commit into
Closed
Conversation
sayan-oai
commented
Jun 23, 2026
| }; | ||
| tokio::spawn(async move { | ||
| let response = tokio::select! { | ||
| response = host.invoke_tool( |
Contributor
Author
There was a problem hiding this comment.
pinned cells from different requests now keep different ToolCallRuntime locks, so two yielded cells can now run a non-parallel tool at the same time. maybe niche, but behavior change + maybe unacceptable
Contributor
Author
|
dropping this: long-lived code-mode cells should use the active step worker and respond to environment/tool changes rather than pinning their original StepContext. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A yielded code-mode cell can keep running after the sampling request that created it ends. Its later tool calls currently use whichever request worker happens to be active.
With dynamic environments, a cell started in workspace A can resume during a later request for workspace B and silently run its tool in B.
What
StepContextfor later nested tool calls.Test
Updated the yielded-cell integration test to start in workspace A, continue during a later turn in workspace B, and verify that a relative command still writes to A.
Stacked on #29547.