Conversation
bolinfest
force-pushed
the
pr29494
branch
2 times, most recently
from
June 22, 2026 23:02
4dcfeb3 to
e29a3af
Compare
bolinfest
marked this pull request as ready for review
June 22, 2026 23:07
pakrym-oai
approved these changes
Jun 22, 2026
Token-budget initial context carries thread and context-window lineage that the model should treat as one structured context-window block. Wrapping it in `<context_window>` makes that boundary explicit while preserving the existing window id content. This adds shared `CONTEXT_WINDOW_*_TAG` protocol constants, updates `TokenBudgetContext` to render with those markers, treats the new wrapper as contextual developer content when mapping history, and refreshes the token-budget request-shape assertions and snapshot. Verification: - `just test -p codex-core token_budget` - `just test -p codex-core recognizes_context_window_as_contextual_developer_content`
bolinfest
enabled auto-merge (squash)
June 22, 2026 23:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Token-budget initial context carries thread and context-window lineage that the model should treat as one structured context-window block. Wrapping it in
<context_window>makes that boundary explicit while preserving the existing window id content.Before this change, the window identifiers were injected as an untagged developer text fragment:
After this change, the same payload is wrapped as a context-window block:
This adds shared
CONTEXT_WINDOW_*_TAGprotocol constants, updatesTokenBudgetContextto render with those markers, treats the new wrapper as contextual developer content when mapping history, and refreshes the token-budget request-shape assertions and snapshot.Verification:
just test -p codex-core token_budgetjust test -p codex-core recognizes_context_window_as_contextual_developer_content