mcp: accept foreign absolute cwd for remote stdio - #29493
Conversation
8882cb4 to
409302e
Compare
409302e to
ab091fd
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab091fdc89
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
aeed608 to
b2bc69d
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40b84c59fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebfc4e7e08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ebfc4e7 to
843c5ba
Compare
| params: Mutex<Option<ExecParams>>, | ||
| } | ||
|
|
||
| impl ExecBackend for RecordingExecBackend { |
There was a problem hiding this comment.
not a fan of unit tests like these but I guess we don't have infra to write better integration ones.
There was a problem hiding this comment.
I'll make a note for my split testing backlog
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Why
Remote stdio MCP servers can run in an environment whose path convention differs from the Codex host. A Windows cwd such as
C:\Users\openai\shareis absolute for the executor but was rejected by a POSIX orchestrator.Built on #29501, now merged, which only clarifies the host-native
PathUriconstructor name.What changed
LegacyAppPathStringso config does not apply host path rules.PathUriat executor launch.codex doctor.Validation
just test -p codex-utils-path-uri -p codex-config -p codex-mcp -p codex-rmcp-client(408 passed)just test -p codex-cli -p codex-rmcp-client(372 passed)cargo check --workspace --testsjust test(11,311 passed; 43 unrelated environment/timing failures)just fix -p codex-cli -p codex-config -p codex-core -p codex-mcp -p codex-mcp-extension -p codex-rmcp-client -p codex-tui