chore: warn when Code Mode lacks model metadata - #29490
Merged
Merged
Conversation
celia-oai
force-pushed
the
codex/warn-unsupported-code-mode
branch
2 times, most recently
from
June 22, 2026 23:18
1d6ad38 to
3a4fa7e
Compare
celia-oai
force-pushed
the
codex/warn-unsupported-code-mode
branch
from
June 22, 2026 23:59
3a4fa7e to
75288dd
Compare
celia-oai
marked this pull request as ready for review
June 23, 2026 00:01
aibrahim-oai
approved these changes
Jun 23, 2026
celia-oai
enabled auto-merge (squash)
June 23, 2026 01:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_modeWhy
Models that predate the catalog-driven Code Mode rollout do not set
ModelInfo.tool_mode. Localcode_modeorcode_mode_onlyfeature overrides can still expose Code Mode to those models, which may degrade tool-use behavior without explaining the unsupported configuration to the user.Explicit model selectors remain authoritative, and fallback-model metadata keeps its existing warning without adding a second warning.
Validation
saw this when running
target/debug/codex --enable code_mode --model gpt-5.5: