Skip to content

[codex] Update esbuild to 0.28.1#29489

Merged
pakrym-oai merged 1 commit into
mainfrom
pakrym/update-esbuild-0.28.1
Jun 22, 2026
Merged

[codex] Update esbuild to 0.28.1#29489
pakrym-oai merged 1 commit into
mainfrom
pakrym/update-esbuild-0.28.1

Conversation

@pakrym-oai

@pakrym-oai pakrym-oai commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Why

The TypeScript workspace resolved esbuild 0.25.10 transitively through the SDK toolchain. esbuild 0.28.1 adds integrity verification to the Deno binary download path addressed by GHSA-gv7w-rqvm-qjhr, preventing an attacker-controlled npm registry from supplying an executable without a content check.

What changed

  • Add a root workspace resolution for esbuild 0.28.1.
  • Regenerate pnpm-lock.yaml so tsup, bundle-require, and ts-jest all resolve the patched version.

Validation

  • Frozen pnpm install, including the SDK's tsup build
  • pnpm --filter @openai/codex-sdk exec jest tests/exec.test.ts --runInBand
  • Confirmed the installed dependency graph contains only esbuild 0.28.1

@pakrym-oai pakrym-oai marked this pull request as ready for review June 22, 2026 22:14

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e16a35a2d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pnpm-lock.yaml
@pakrym-oai pakrym-oai merged commit 7ce84e6 into main Jun 22, 2026
46 of 47 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/update-esbuild-0.28.1 branch June 22, 2026 23:00
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants