Skip to content

fix(config): address permission profile review follow-ups #29479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viyatb-oai merged 1 commit into from
Jun 22, 2026
+6 −4
Merged

fix(config): address permission profile review follow-ups #29479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codex-rs/core/src/config/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4108,7 +4108,7 @@ impl Config {
}

/// Returns whether effective requirements allow selecting a concrete profile.
pub fn permission_profile_allowed(
pub fn is_permission_profile_allowed(
&self,
profile_id: &str,
permission_profile: &PermissionProfile,
Expand Down
5 changes: 3 additions & 2 deletions codex-rs/tui/src/chatwidget/permissions_menu.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
use super::*;
use codex_protocol::models::BUILT_IN_PERMISSION_PROFILE_DANGER_FULL_ACCESS;

impl ChatWidget {
pub(super) fn open_permission_profiles_popup(&mut self) {
Expand Down Expand Up @@ -48,7 +49,7 @@ impl ChatWidget {
}
items.push(self.builtin_permission_mode_selection_item(
full_access,
":danger-full-access",
BUILT_IN_PERMISSION_PROFILE_DANGER_FULL_ACCESS,
full_access.description.to_string(),
AskForApproval::from(full_access.approval),
ApprovalsReviewer::User,
Expand Down Expand Up @@ -146,7 +147,7 @@ impl ChatWidget {
.or_else(|| {
(!self
.config
.permission_profile_allowed(id, &preset.permission_profile))
.is_permission_profile_allowed(id, &preset.permission_profile))
.then(|| "Disabled by requirements.".to_string())
}),
..Default::default()
Expand Down
3 changes: 2 additions & 1 deletion codex-rs/tui/src/chatwidget/tests/permissions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use super::*;
use crate::legacy_core::config::PermissionProfileCatalogEntry;
use codex_protocol::models::ActivePermissionProfile;
use codex_protocol::models::BUILT_IN_PERMISSION_PROFILE_DANGER_FULL_ACCESS;
use codex_protocol::models::ManagedFileSystemPermissions;
use codex_protocol::permissions::FileSystemAccessMode;
use codex_protocol::permissions::FileSystemPath;
Expand Down Expand Up @@ -283,7 +284,7 @@ async fn profile_permissions_full_access_opens_confirmation() {
display_label,
}),
} if preset.id == "full-access"
&& profile_id == ":danger-full-access"
&& profile_id == BUILT_IN_PERMISSION_PROFILE_DANGER_FULL_ACCESS
&& display_label == "Full Access"
));
}
Expand Down
Loading