[codex] Expose service tier and reasoning effort in OTEL - #29155
Merged
Conversation
owenlin0
reviewed
Jun 22, 2026
| model: model.to_owned(), | ||
| slug: slug.to_owned(), | ||
| service_tier: None, | ||
| model_reasoning_effort: None, |
Contributor
There was a problem hiding this comment.
can we populate these values upstream? service_tier and model_reasoning_effort are thread-level settings, similar to model
that way we can get rid of with_inference_request
owenlin0
reviewed
Jun 22, 2026
owenlin0
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NVIDIA asked to measure Fast mode usage and reasoning effort from Codex CLI OTEL logs. Add the finalized
service_tierandmodel_reasoning_effortto the existingcodex.sse_eventresponse.completedrecord.This intentionally reuses the existing completion event and leaves transport APIs and shared telemetry plumbing unchanged.
Testing
cargo build -p codex-cli --bin codexjust test -p codex-core responses_api_emits_api_request_eventservice_tier=priorityandmodel_reasoning_effort=highwith token usage.service_tierand emittedmodel_reasoning_effort=lowwith token usage.