build: use gnullvm for Windows Rust exec tools#29149
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ef24a6143
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b5398ae to
dc6ad5e
Compare
5fcabf0 to
8494332
Compare
8494332 to
871d868
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
going to try this from the top, fixing v8 first |
Why
#29143 provides a pinned LLVM/MinGW toolchain, but Windows Bazel lint actions could still select the generic MSVC nightly for exec-side Rust tools or resolve host tools from the runner. This is the first step toward making Windows Bazel compile, proc-macro, and build-script actions hermetic.
Parent PR: #29143.
What
x86_64-pc-windows-gnullvmfor both exec and target configurations, including the pinnedrustc-devcomponents used by the lint driver.rust-lldaslld-link.exeinstead of searchingPATH.Validation
rustc-devand replaces the competing x64 MSVC registration.aqueryoutput to verify gnullvmrustc, the hermetic Clang driver, MinGW/UCRT/CRT inputs, matched build-script producer/runner platforms, native Windows Rust/lint execution, and Linux-only V8 host-tool/native execution.just bazel-lock-checkand the Bazel wrapper's Python test suite.