Skip to content

Namespace multi-agent v2 tools under collaboration - #29067

Merged
jif-oai merged 8 commits into
mainfrom
jif/namespace-mav2
Jun 23, 2026
Merged

Namespace multi-agent v2 tools under collaboration#29067
jif-oai merged 8 commits into
mainfrom
jif/namespace-mav2

Conversation

@jif-oai

@jif-oai jif-oai commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Multi-agent v2 tools now use the fixed collaboration namespace when namespace tools are available. This keeps the model-visible hint and the actual tool surface aligned around functions.collaboration.*, without exposing an unshipped namespace knob to users.

The PR also removes the old features.multi_agent_v2.tool_namespace config/schema surface, updates the MAv2 test fixtures for namespaced calls, and fixes stale TurnContext.features references that were breaking codex-core builds.

Changes

  • Expose MAv2 tools under collaboration instead of relying on a configurable namespace.
  • Remove tool_namespace from MAv2 TOML config, resolved config, validation, schema, and tests.
  • Update tool-planning and integration fixtures to assert or emit namespaced MAv2 tool calls.
  • Read feature state through TurnContext.config.features in the multi-agent mode context paths.

Testing

  • just write-config-schema
  • just test -p codex-features

@jif-oai
jif-oai requested a review from a team as a code owner June 19, 2026 08:50

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f6d5c11afd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/config/mod.rs
Comment thread codex-rs/core/src/config/mod.rs
Comment thread codex-rs/core/src/config/mod.rs
Comment thread codex-rs/core/src/config/mod.rs
@jif-oai

jif-oai commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d7ab71fbf3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/features/src/feature_configs.rs
Comment thread codex-rs/core/src/tools/spec_plan.rs Outdated
@jif-oai
jif-oai force-pushed the jif/namespace-mav2 branch from 30d146a to 0f8faee Compare June 19, 2026 10:06
jif-oai added 3 commits June 23, 2026 10:37
# Conflicts:
#	codex-rs/core/tests/suite/model_runtime_selectors.rs
#	codex-rs/core/tests/suite/rollout_budget.rs
@jif-oai
jif-oai enabled auto-merge (squash) June 23, 2026 11:50
@jif-oai
jif-oai disabled auto-merge June 23, 2026 12:15
@jif-oai
jif-oai merged commit 49614a0 into main Jun 23, 2026
30 of 31 checks passed
@jif-oai
jif-oai deleted the jif/namespace-mav2 branch June 23, 2026 12:15
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants