Skip to content

[codex] Remove child AGENTS.md prompt experiment - #28993

Merged
pakrym-oai merged 1 commit into
mainfrom
pakrym/remove-child-agents-md
Jun 18, 2026
Merged

[codex] Remove child AGENTS.md prompt experiment#28993
pakrym-oai merged 1 commit into
mainfrom
pakrym/remove-child-agents-md

Conversation

@pakrym-oai

Copy link
Copy Markdown
Contributor

Why

child_agents_md is a disabled, under-development experiment that adds a second model-visible explanation of hierarchical AGENTS.md behavior. Keeping it leaves unused prompt, configuration, documentation, and test surface.

What changed

  • remove the ChildAgentsMd feature and child_agents_md config schema entry
  • remove the hierarchical prompt asset, export, and instruction injection
  • remove feature-specific tests and documentation
  • keep the generic unstable-feature warning coverage using apply_patch_streaming_events

Normal project AGENTS.md discovery and composition are unchanged.

Testing

  • just test -p codex-features
  • just test -p codex-prompts
  • just test -p codex-core agents_md
  • just test -p codex-core unstable_features_warning

@pakrym-oai
pakrym-oai requested a review from a team as a code owner June 18, 2026 22:36

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 011beedcc1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 912 to 913
id: Feature::ApplyPatchFreeform,
key: "apply_patch_freeform",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve child_agents_md as a removed compatibility flag

When a user or wrapper still passes --enable child_agents_md, or runs --strict-config with [features].child_agents_md in config.toml, this key is now unknown because is_known_feature_key only recognizes entries from FEATURES and legacy aliases. That blocks CLI startup or strict config loading instead of treating the removed experiment as a no-op; keep a Stage::Removed registry entry/alias for child_agents_md like the other removed feature flags.

AGENTS.md reference: AGENTS.md:L103-L110

Useful? React with 👍 / 👎.

@pakrym-oai
pakrym-oai merged commit bb72e15 into main Jun 18, 2026
31 checks passed
@pakrym-oai
pakrym-oai deleted the pakrym/remove-child-agents-md branch June 18, 2026 23:13
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants