Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codex-rs/thread-store/src/in_memory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ mod tests {
let items_err = store
.list_items(ListItemsParams {
thread_id,
turn_id: "turn_1".to_string(),
turn_id: None,
include_archived: true,
cursor: None,
page_size: 10,
Expand Down
2 changes: 1 addition & 1 deletion codex-rs/thread-store/src/store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ pub trait ThreadStore: Any + Send + Sync {
})
}

/// Lists persisted items within a stored turn.
/// Lists persisted items within a stored thread, optionally filtered to a turn.
fn list_items(&self, _params: ListItemsParams) -> ThreadStoreFuture<'_, ItemPage> {
Box::pin(async {
Err(ThreadStoreError::Unsupported {
Expand Down
8 changes: 4 additions & 4 deletions codex-rs/thread-store/src/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -332,13 +332,13 @@ pub struct TurnPage {
pub backwards_cursor: Option<String>,
}

/// Parameters for listing persisted items within a single turn.
/// Parameters for listing persisted items within a thread.
#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
pub struct ListItemsParams {
/// Thread id to read.
pub thread_id: ThreadId,
/// Turn id to hydrate.
pub turn_id: String,
/// Optional turn id to filter by. When omitted, returns items across the thread.
pub turn_id: Option<String>,
/// Whether archived threads are eligible.
pub include_archived: bool,
/// Opaque cursor returned by a previous list call.
Expand All @@ -359,7 +359,7 @@ pub struct StoredThreadItem {
pub materialized_thread_item_json: Vec<u8>,
}

/// A page of persisted items within a turn.
/// A page of persisted items within a thread, optionally filtered to a turn.
#[derive(Clone, Debug, Serialize, Deserialize)]
pub struct ItemPage {
/// Items returned for this page.
Expand Down
Loading