[codex] Enable auth elicitation by default - #28772
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db4e9c635d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…-elicitation # Conflicts: # codex-rs/core/tests/suite/mod.rs
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
…-elicitation # Conflicts: # codex-rs/core/src/mcp_tool_call_tests.rs # codex-rs/core/tests/suite/mod.rs
adaley-openai
approved these changes
Jul 7, 2026
owenlin0
reviewed
Jul 7, 2026
| @@ -0,0 +1,216 @@ | |||
| #![cfg(not(target_os = "windows"))] | |||
Contributor
There was a problem hiding this comment.
hm does this test not work on windows?
Contributor
Author
There was a problem hiding this comment.
it should, reverted, good catch!
owenlin0
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auth_elicitationby defaultStable, as default-enabled features must be stableImpact
Auth elicitation is now available without requiring users or clients to opt in through configuration.
Testing
just test -p codex-features(52 passed)