Skip to content

Extract TUI plugin catalog rendering#28768

Merged
canvrno-oai merged 2 commits into
mainfrom
canvrno/plugin_sharing_tui_plugin_catalog_extraction
Jun 17, 2026
Merged

Extract TUI plugin catalog rendering#28768
canvrno-oai merged 2 commits into
mainfrom
canvrno/plugin_sharing_tui_plugin_catalog_extraction

Conversation

@canvrno-oai

Copy link
Copy Markdown
Contributor

This mechanically extracts the existing TUI plugin catalog and detail popup rendering from chatwidget/plugins.rs into a new chatwidget/plugin_catalog.rs module. plugins.rs now keeps the stateful plugin workflow and orchestration, while plugin_catalog.rs owns the presentation-heavy catalog/detail popup construction and its pure helpers. The goal is to keep plugins.rs focused before later plugin sharing work adds more catalog behavior.

  • Moves existing catalog/detail popup builders and related pure helpers into plugin_catalog.rs
  • Leaves plugin fetch/state/key handling in plugins.rs
  • Adds only minimal sibling-module visibility/import wiring
  • Intentionally makes no product behavior or UI changes beyond the code move

@canvrno-oai canvrno-oai force-pushed the canvrno/plugin_sharing_tui_plugin_catalog_extraction branch from 495315f to c5dc99c Compare June 17, 2026 18:24
@canvrno-oai canvrno-oai marked this pull request as ready for review June 17, 2026 18:42
@canvrno-oai

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: fb1e5fc430

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@canvrno-oai canvrno-oai merged commit b668abb into main Jun 17, 2026
31 checks passed
@canvrno-oai canvrno-oai deleted the canvrno/plugin_sharing_tui_plugin_catalog_extraction branch June 17, 2026 18:57
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants