Skip to content

[codex] Persist built-in image results reported as generating #28656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
won-openai merged 4 commits into from
Jun 17, 2026
+4 −4
Merged

[codex] Persist built-in image results reported as generating #28656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7eaa398
Persist terminal image generation results
won-openai Jun 17, 2026
9227857
Simplify image generation persistence coverage
won-openai Jun 17, 2026
07d3c20
Simplify image generation persistence condition
won-openai Jun 17, 2026
20a805f
Merge branch 'main' into won-fix-image-generation-artifact-persistence
won-openai Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codex-rs/core/src/stream_events_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ pub(crate) async fn finalize_turn_item(
}
}
if let TurnItem::ImageGeneration(image_item) = &mut *turn_item
&& image_item.status == "completed"
&& !image_item.result.is_empty()
{
persist_image_generation_item(sess, turn_context, image_item).await;
}
Expand Down
6 changes: 3 additions & 3 deletions codex-rs/core/tests/suite/items.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ async fn web_search_item_is_emitted() -> anyhow::Result<()> {
}

#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn image_generation_call_event_is_emitted() -> anyhow::Result<()> {
async fn builtin_image_generation_call_persisted() -> anyhow::Result<()> {
skip_if_no_network!(Ok(()));

let server = start_mock_server().await;
Expand All @@ -369,7 +369,7 @@ async fn image_generation_call_event_is_emitted() -> anyhow::Result<()> {

let first_response = sse(vec![
ev_response_created("resp-1"),
ev_image_generation_call(call_id, "completed", "A tiny blue square", "Zm9v"),
ev_image_generation_call(call_id, "generating", "A tiny blue square", "Zm9v"),
ev_completed("resp-1"),
]);
mount_sse_once(&server, first_response).await;
Expand Down Expand Up @@ -422,7 +422,7 @@ async fn image_generation_call_event_is_emitted() -> anyhow::Result<()> {
assert_eq!(completed.0.id, call_id);
assert!(completed.1 > 0);
assert_eq!(end.call_id, call_id);
assert_eq!(end.status, "completed");
assert_eq!(end.status, "generating");
assert_eq!(end.revised_prompt, Some("A tiny blue square".to_string()));
assert_eq!(end.result, "Zm9v");
assert_eq!(
Expand Down
Loading