[codex] suppress low usage remaining warnings when credits are available - #28593
Merged
Conversation
brooks-oai
force-pushed
the
codex/suppress-usage-warnings-with-credits
branch
from
June 16, 2026 21:50
83bfda7 to
77d916c
Compare
brooks-oai
marked this pull request as ready for review
June 16, 2026 21:54
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77d916c344
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dhruvgupta-oai
approved these changes
Jun 24, 2026
dhruvgupta-oai
enabled auto-merge (squash)
June 24, 2026 18:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The TUI computed proactive
Heads up, you have less than ...warnings before considering workspace credits. As a result, users could see included-limit warnings even when they could continue using Codex with workspace credits.has_creditsalone is not sufficient to determine whether finite credits are usable: a spend-control hard limit can cap the reported balance to zero whilehas_creditsstill reflects the workspace's raw balance. Unlimited credits are the opposite case: they are usable even though no numeric balance is reported.What changed
has_creditsis true and eitherunlimitedis true or the parsed balance is positiveValidation
just test -p codex-tui rate_limit_usage_warnings_