fix(tui): highlight C++ module files - #28554
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11b37e75d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13b40b2b4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
etraut-openai
left a comment
There was a problem hiding this comment.
Code looks good.
I didn't bother building or manually testing this one since it's pretty simple and has low regression risk.
Why
Codex syntax-highlights diffs for conventional C++ extensions such as
.cppand.cxx, but C++ module interface files using.cppm,.ixx, or.cxxmfall back to plain diff coloring. The bundled syntax set already includes C++, but it does not resolve those module extensions by itself.Closes #28223.
What changed
.cppm,.ixx, and.cxxmto the existingcppsyntax inrender/highlight.rs.cpp,.cppm,.ixx, and.cxxmdiffs produce syntax-highlighted RGB spans while unknown extensions retain the plain fallbackHow to Test
.cppm,.ixx, or.cxxm..cppfile and confirm its existing highlighting remains unchanged.Targeted tests:
just test -p codex-tui -E 'test(find_syntax_resolves_languages_and_aliases) | test(cpp_module_extensions_use_cpp_highlighting) | test(unknown_extension_falls_back_without_syntax_highlighting)'