chore(core) rm AskForApproval::OnFailure - #28418
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56ec473e80
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dylan-hurd-oai
added a commit
that referenced
this pull request
Jun 16, 2026
dylan-hurd-oai
force-pushed
the
dh--rm--on-failure
branch
from
June 16, 2026 05:28
56ec473 to
756e6a2
Compare
dylan-hurd-oai
added a commit
that referenced
this pull request
Jun 16, 2026
dylan-hurd-oai
commented
Jun 17, 2026
|
|
||
| #[cfg(not(target_os = "linux"))] | ||
| #[tokio::test] | ||
| async fn permission_request_hook_sees_retry_context_after_sandbox_denial() -> Result<()> { |
Contributor
Author
There was a problem hiding this comment.
cc @eternal-openai confirming we can delete this test?
aibrahim-oai
approved these changes
Jun 17, 2026
dylan-hurd-oai
force-pushed
the
dh--rm--on-failure
branch
from
June 23, 2026 14:48
3324be8 to
b9b9527
Compare
dylan-hurd-oai
enabled auto-merge (squash)
June 23, 2026 14:51
dylan-hurd-oai
disabled auto-merge
June 23, 2026 16:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes the OnFailure variant of the
AskForApprovalenum. This option has been deprecated since #11631.Testing