feat(network-proxy): experimental local credential broker - #28034
Merged
Conversation
winston-openai
force-pushed
the
dev/winston/local-credential-broker
branch
6 times, most recently
from
June 13, 2026 08:36
5446ca3 to
006a77a
Compare
winston-openai
marked this pull request as ready for review
June 16, 2026 01:51
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 006a77a3d6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
winston-openai
added a commit
that referenced
this pull request
Jun 16, 2026
winston-openai
added a commit
that referenced
this pull request
Jun 16, 2026
winston-openai
added a commit
that referenced
this pull request
Jun 16, 2026
This was referenced Jun 16, 2026
winston-openai
added a commit
that referenced
this pull request
Jun 16, 2026
winston-openai
added a commit
that referenced
this pull request
Jun 16, 2026
winston-openai
added a commit
that referenced
this pull request
Jun 17, 2026
This was referenced Jun 17, 2026
winston-openai
force-pushed
the
dev/winston/local-credential-broker
branch
from
June 17, 2026 18:45
f992518 to
732cf55
Compare
winston-openai
changed the base branch from
dev/winston/mitm-command-ca-bundles
to
main
June 17, 2026 18:46
winston-openai
force-pushed
the
dev/winston/local-credential-broker
branch
2 times, most recently
from
June 17, 2026 20:03
807dfe6 to
f52cce3
Compare
winston-openai
force-pushed
the
dev/winston/local-credential-broker
branch
3 times, most recently
from
June 18, 2026 18:44
99eeb43 to
9204084
Compare
viyatb-oai
force-pushed
the
dev/winston/local-credential-broker
branch
from
June 23, 2026 21:55
b357b3c to
bf99b76
Compare
viyatb-oai
force-pushed
the
dev/winston/local-credential-broker
branch
2 times, most recently
from
June 24, 2026 00:13
5c12c9b to
09bd01e
Compare
viyatb-oai
approved these changes
Jun 24, 2026
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
viyatb-oai
force-pushed
the
dev/winston/local-credential-broker
branch
from
June 24, 2026 01:57
09bd01e to
d1613d0
Compare
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
…dential-providers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Codex child processes can inherit injectable local credentials directly, which lets commands read and exfiltrate the real values. This experimental slice keeps supported workflows working while moving those credentials behind the managed network proxy.
This PR contains only the proxy-owned broker implementation. The Codex config and runtime integration is stacked separately in #29752.
What changed
Scope
GH_TOKEN,GITHUB_TOKEN,GH_ENTERPRISE_TOKEN,GITHUB_ENTERPRISE_TOKEN, andOPENAI_API_KEYgithub.com,api.github.com, and*.ghe.comGH_HOSTapi.openai.comValidation
just test -p codex-network-proxy(191 passed)codex-network-proxypassed