Skip to content

[codex] Limit app-based plugin suggestions to remote catalogs - #27988

Merged
xl-openai merged 2 commits into
mainfrom
xl/plguins2
Jun 13, 2026
Merged

[codex] Limit app-based plugin suggestions to remote catalogs#27988
xl-openai merged 2 commits into
mainfrom
xl/plguins2

Conversation

@xl-openai

Copy link
Copy Markdown
Contributor

Summary

  • Keep local plugin suggestions bounded to fallback and explicitly configured plugins.
  • Preserve app-overlap recommendations for remote plugins using cached catalog metadata.
  • Remove the WSL-specific local discovery exception and move manager-owned discovery tests into codex-core-plugins.

Why

Local curated marketplaces were allowlisted before plugin detail loading, so every uninstalled candidate could be deep-read before its app IDs were checked. That caused per-turn reads of candidate plugin manifests, skills, app configs, hooks, and MCP configs, which is especially expensive on slow disks.

Remote discovery does not need those local candidate reads because app IDs are already available in the cached remote catalog. Installed local plugins are still loaded when needed to determine the user's installed app IDs.

Validation

  • just fmt
  • just test -p codex-core-plugins discoverable::tests (13 passed)
  • just test -p codex-core plugins::discoverable::tests (4 passed)
  • just bazel-lock-update
  • just bazel-lock-check
  • git diff --check

@xl-openai
xl-openai marked this pull request as ready for review June 13, 2026 00:33
@xl-openai
xl-openai requested a review from a team as a code owner June 13, 2026 00:33

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13b29654fb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core-plugins/Cargo.toml
Comment thread codex-rs/core-plugins/src/discoverable.rs
@xl-openai
xl-openai merged commit 044c142 into main Jun 13, 2026
31 checks passed
@xl-openai
xl-openai deleted the xl/plguins2 branch June 13, 2026 00:51
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants