feat(app-server): enforce managed remote control disable - #27961
Conversation
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1f9d5e195
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d391816016
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4ef520440
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fn deserialize_client_request( | ||
| request: &JSONRPCRequest, | ||
| ) -> Result<ClientRequest, JSONRPCErrorError> { |
There was a problem hiding this comment.
This extracts deserialize_client_request, but the only caller is the replacement below, so it adds an extra abstraction for a single use. The repo guidance asks not to add small helpers that are referenced only once; keeping this inline avoids the churn. guidance
Useful? React with 👍 / 👎.
Why
Managed deployments need a reliable deny gate for remote control. Persisted enablement and explicit startup requests currently remain able to start the transport, while the removed
features.remote_controlkey is intentionally only a compatibility no-op.This adds a dedicated requirement that administrators can use to force remote control off without deleting the user's persisted preference. Removing the requirement and restarting restores the prior choice.
What Changed
allow_remote_controlrequirements parsing, sourced layer precedence, debug output, andconfigRequirements/readexposure asallowRemoteControl.remoteControl/*RPC before parameter deserialization with JSON-RPC-32600andremote control is disabled by managed requirements.trueor omitted.Verification
disabled.allow_remote_control = truedoes not enable or block remote control andconfigRequirements/readreturnsallowRemoteControl: falsefor the deny policy.Related issue: N/A (managed-policy hardening).