[codex] Add hermetic Wine exec-server test - #27937
Merged
Merged
Conversation
anp-oai
commented
Jun 12, 2026
anp-oai
commented
Jun 12, 2026
anp-oai
marked this pull request as ready for review
June 12, 2026 20:56
Contributor
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89c7b9d95b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anp-oai
force-pushed
the
codex/wine-exec-server-test
branch
from
June 12, 2026 22:21
89c7b9d to
78b64c6
Compare
anp-oai
force-pushed
the
codex/wine-exec-server-test
branch
from
June 12, 2026 23:00
78b64c6 to
695cc3a
Compare
anp-oai
commented
Jun 12, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 12, 2026
anp-oai
commented
Jun 12, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 12, 2026
pakrym-oai
approved these changes
Jun 13, 2026
anp-oai
force-pushed
the
codex/wine-exec-server-test
branch
from
June 13, 2026 01:34
8d9b1a1 to
573477f
Compare
anp-oai
commented
Jun 13, 2026
anp-oai
commented
Jun 13, 2026
anp-oai
commented
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We want to make it possible for an app-server orchestrator on one OS to control an exec-server on another host running a different OS. In practice this kinda already works if you get lucky and the two hosts have the same path format, but we mangle quite a lot of operations if either end is Windows.
This test starts exercising that interaction, although right now the initial bootstrap fails. Future changes will expand the test's assertions to match improved support.
What
Stacked on #27964. This adds a small Windows exec-server fixture and a Linux protocol smoke test using the reusable Wine harness, covering Windows environment discovery, non-TTY
cmd.exeexecution, output, exit status, and working directory.Once we've got the full codex binary cross-building under Bazel we could consider moving to the real binary instead of the stripped down exec-server-only binary used here.