[codex] Align implicit skill reads with parser - #27926
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8961dbcec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| codex-model-provider = { workspace = true } | ||
| codex-otel = { workspace = true } | ||
| codex-protocol = { workspace = true } | ||
| codex-shell-command = { workspace = true } |
There was a problem hiding this comment.
Commit the Bazel lockfile update
Because this adds a Rust workspace dependency, the Bazel module lock must be refreshed and committed; otherwise Bazel lock/check can fail in CI or for Bazel users until the just bazel-lock-update output is included, per repo guidance.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Ran just bazel-lock-update and just bazel-lock-check; both pass and MODULE.bazel.lock has no diff to commit.
Summary
nl -ba .../SKILL.mdWhy
Desktop could render
Read User Context skillfor reads recognized by the shared command parser, while implicitskill_invocationanalytics used a separate reader allowlist and missed cases such asnl.Validation
HOME=/private/tmp/codex-core-skills-home-pr PATH=/Users/alexsong/.cache/cargo-home/bin:$PATH CARGO_HOME=/Users/alexsong/.cache/cargo-home just test -p codex-core-skillsgit diff --cached --checkjust fmtattempted; Rust formatting completed, but the Python formatters could not download uncached Ruff wheels becausefiles.pythonhosted.orgis blocked in this sandbox.bazel mod deps --lockfile_mode=update/error --repo_env=ASPECT_TOOLS_TELEMETRY= --repo_env=DO_NOT_TRACK=1evaluated the module graph and produced noMODULE.bazel.lockdiff, but Bazel crashed on sandboxedsysctlduring exit.