Skip to content

[codex] Align implicit skill reads with parser - #27926

Merged
alexsong-oai merged 1 commit into
mainfrom
codex/align-implicit-skill-reads-with-parser
Jun 12, 2026
Merged

[codex] Align implicit skill reads with parser#27926
alexsong-oai merged 1 commit into
mainfrom
codex/align-implicit-skill-reads-with-parser

Conversation

@alexsong-oai

Copy link
Copy Markdown
Contributor

Summary

  • reuse the shared shell read parser for implicit skill doc invocation detection
  • add regression coverage for nl -ba .../SKILL.md

Why

Desktop could render Read User Context skill for reads recognized by the shared command parser, while implicit skill_invocation analytics used a separate reader allowlist and missed cases such as nl.

Validation

  • HOME=/private/tmp/codex-core-skills-home-pr PATH=/Users/alexsong/.cache/cargo-home/bin:$PATH CARGO_HOME=/Users/alexsong/.cache/cargo-home just test -p codex-core-skills
  • git diff --cached --check
  • just fmt attempted; Rust formatting completed, but the Python formatters could not download uncached Ruff wheels because files.pythonhosted.org is blocked in this sandbox.
  • bazel mod deps --lockfile_mode=update/error --repo_env=ASPECT_TOOLS_TELEMETRY= --repo_env=DO_NOT_TRACK=1 evaluated the module graph and produced no MODULE.bazel.lock diff, but Bazel crashed on sandboxed sysctl during exit.

@alexsong-oai
alexsong-oai marked this pull request as ready for review June 12, 2026 18:32
@alexsong-oai

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d8961dbcec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-model-provider = { workspace = true }
codex-otel = { workspace = true }
codex-protocol = { workspace = true }
codex-shell-command = { workspace = true }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Commit the Bazel lockfile update

Because this adds a Rust workspace dependency, the Bazel module lock must be refreshed and committed; otherwise Bazel lock/check can fail in CI or for Bazel users until the just bazel-lock-update output is included, per repo guidance.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran just bazel-lock-update and just bazel-lock-check; both pass and MODULE.bazel.lock has no diff to commit.

Comment thread codex-rs/core-skills/src/invocation_utils.rs
Comment thread codex-rs/core-skills/src/invocation_utils.rs
Comment thread codex-rs/core-skills/src/invocation_utils.rs
@alexsong-oai
alexsong-oai merged commit a57087a into main Jun 12, 2026
31 checks passed
@alexsong-oai
alexsong-oai deleted the codex/align-implicit-skill-reads-with-parser branch June 12, 2026 20:23
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants