fix: serialize auth environment tests - #27879
Merged
Merged
Conversation
jif-oai
force-pushed
the
jif/fix-pat-auth-env-test-flake
branch
from
June 12, 2026 14:14
4f58a4b to
7192731
Compare
jif-oai
marked this pull request as ready for review
June 12, 2026 14:16
cooper-oai
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex_auth_envserial groupRoot cause
The login unit-test binary runs tests concurrently. One test removed
CODEX_ACCESS_TOKENwithout joining the existing serial group, while several Bedrock tests constructedAuthManagerand read that same process-global environment outside the group. An interleaving could restore a stale personal access token while another test was loading file-backed auth, causing the observed mismatched/whoamirequest count and related auth-state flakes.Verification
just fmtgit diff --checkbazel test //codex-rs/login:login-unit-tests --nocache_test_results --runs_per_test=20 --test_output=errors(20/20 passed)just test -p codex-login(135/135 passed)