Skip to content

sandboxing: migrate cwd inputs to PathUri - #27816

Merged
anp-oai merged 3 commits into
mainfrom
codex/sandbox-cwd-path-uri
Jun 12, 2026
Merged

sandboxing: migrate cwd inputs to PathUri#27816
anp-oai merged 3 commits into
mainfrom
codex/sandbox-cwd-path-uri

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Why

Sandbox cwd values can cross app-server and exec-server host boundaries. They should retain URI semantics until the receiving host validates them instead of being interpreted early as native paths.

What

  • Carry PathUri through filesystem sandbox contexts, sandbox commands, and transform inputs.
  • Convert command and policy cwd once in SandboxManager::transform, then keep launch requests native.
  • Preserve sandbox cwd over remote filesystem transport and reject non-native URIs without fallback.
  • Cache paired native/URI turn-environment cwd values during migration, with immutable access to keep them synchronized.
  • Extend existing protocol, forwarding, transform, and core runtime tests.

@anp-oai
anp-oai force-pushed the codex/sandbox-cwd-path-uri branch from 4f591c3 to 9fe5d6d Compare June 12, 2026 08:00
@anp-oai
anp-oai marked this pull request as ready for review June 12, 2026 08:22
@anp-oai
anp-oai requested a review from a team as a code owner June 12, 2026 08:22
@anp-oai
anp-oai marked this pull request as draft June 12, 2026 08:26

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9fe5d6d3c5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/sandboxing/Cargo.toml
@anp-oai
anp-oai marked this pull request as ready for review June 12, 2026 16:50
Comment thread codex-rs/sandboxing/src/manager.rs
@anp-oai
anp-oai force-pushed the codex/sandbox-cwd-path-uri branch from ecf54b9 to db68524 Compare June 12, 2026 17:02
Comment thread codex-rs/sandboxing/src/manager_tests.rs Outdated
@anp-oai
anp-oai merged commit 52a50ae into main Jun 12, 2026
31 checks passed
@anp-oai
anp-oai deleted the codex/sandbox-cwd-path-uri branch June 12, 2026 18:38
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants