tui: Allow extra o's in /goal command - #27814
Merged
Merged
Conversation
btraut-openai
marked this pull request as ready for review
June 12, 2026 07:46
etraut-openai
approved these changes
Jun 12, 2026
etraut-openai
left a comment
Contributor
There was a problem hiding this comment.
OK, that's kinda cute. :)
Contributor
|
Make sure to investigate the CI failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The TUI rejected playful
/goalspellings such as/goooooooooooal, even though Codex Apps accepts them for the World Cup promotion. This keeps the TUI behavior consistent without changing how the canonical command is presented.How it works
Built-in command lookup recognizes lowercase
go+alas the existinggoalcommand after normal exact-name parsing fails. The command catalog remains unchanged, so autocomplete continues to advertise/goalnormally.Verification
Added lookup-level and end-to-end TUI coverage for the flexible spelling. The focused tests, scoped Clippy checks, and formatting pass. The full
codex-tuisuite passed 2,833 of 2,835 tests; the two failing guardian feature-flag tests reproduce unchanged on freshorigin/main.