[codex] Reuse Apps policy evaluation across MCP tool exposure - #27813
Merged
Conversation
mzeng-openai
force-pushed
the
dev/mzeng/reuse-app-tool-policy-evaluator
branch
from
June 12, 2026 18:01
f34d2fc to
eb2b726
Compare
mzeng-openai
marked this pull request as ready for review
June 12, 2026 19:00
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc8e962fba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pakrym-oai
reviewed
Jun 12, 2026
owenlin0
approved these changes
Jun 15, 2026
owenlin0
left a comment
Contributor
There was a problem hiding this comment.
nice on moving this out of codex-core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppToolPolicyEvaluatorand the Apps config/requirements policy logic fromcodex-coreintocodex-connectorsWhy
build_mcp_tool_exposureevaluates every Codex Apps tool on each sampling request. The old path rebuilt effective Apps configuration for every tool, and the policy implementation lived in the already-large core crate even though it is connector-specific.The connector-owned evaluator keeps the expensive config merge/decode out of the loop and gives core only the effective policy result it needs.
Performance
With the real 557-tool Apps corpus,
build_mcp_tool_exposuremeasured 3.74 ms and 3.33 ms after the extraction (3.54 ms mean). The original path measured 807 ms mean, so the final result retains the 99.6% reduction.Validation
cargo check -p codex-connectors -p codex-corejust test -p codex-connectors— 15 passedjust test -p codex-core --lib connectors— 35 passedjust test -p codex-core --lib mcp_tool_exposure— 5 passedjust test -p codex-core --lib mcp_tool_call— 72 passedjust bazel-lock-updatejust bazel-lock-checkjust fix -p codex-connectorsjust fix -p codex-corejust fmt