Persist update dismissal without cache - #27783
Merged
Merged
Conversation
etraut-openai
marked this pull request as ready for review
June 12, 2026 05:52
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41408389e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fcoury-oai
approved these changes
Jun 12, 2026
fcoury-oai
left a comment
Contributor
There was a problem hiding this comment.
I was able to validate the fix.
Codex noticed that the recreated cache records Utc::now() despite no update check occurring, which can delay the next real update check by up to 20 hours; it recommend using a stale timestamp or otherwise forcing a refresh on the next startup.
Otherwise the code also looks good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Choosing “Don’t remind me” can silently fail when
version.jsondisappears before dismissal becausedismiss_versionreturns success without writing anything. The same update can then reappear on the next launch.Initialize a minimal
VersionInfofrom the selected version when the cache cannot be read, then persist the dismissal through the existing write path.Fixes #27147