ci(v8): gate Windows source builds on relevant changes - #27715
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30c334f609
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
|
|
||
| def changed_files(base: str, head: str) -> set[str]: | ||
| output = git_output("diff", "--name-only", "--no-renames", base, head) |
There was a problem hiding this comment.
Codex thinks this is going to miss some things:
git diff base head includes changes made only on main after a PR branched. A stale PR can therefore unnecessarily trigger the two multi-hour Windows builds. PR comparisons should use the merge base, matching GitHub’s three-dot comparison model.
Seems legit?
There was a problem hiding this comment.
Nice. Yes this is updated now with the test for it.
Avoid rebuilding sandboxed Windows MSVC V8 artifacts for unrelated changes to
codex-rs/Cargo.toml.The V8 canary now compares the resolved V8 version between the base and head commits and only runs the Windows source-build matrix when:
The existing Bazel V8 matrix is unchanged.
Why
The Windows MSVC source builds take roughly two to three hours and currently run whenever any entry in the broad
v8-canarypath filter changes.