[codex] add latency tracing spans - #27710
Merged
Merged
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
rphilizaire-openai
marked this pull request as ready for review
June 12, 2026 02:08
pakrym-oai
approved these changes
Jun 12, 2026
pakrym-oai
reviewed
Jun 12, 2026
| let requested_cwd = typesafe_overrides.cwd.clone(); | ||
| let mut config = config_manager | ||
| .load_with_overrides(config_overrides.clone(), typesafe_overrides.clone()) | ||
| .instrument(info_span!("app_server.thread_start.load_config")) |
Contributor
There was a problem hiding this comment.
- should probably be on the method
pakrym-oai
approved these changes
Jun 12, 2026
rphilizaire-openai
force-pushed
the
dev/rphilizaire/codex-latency-spans
branch
from
June 12, 2026 23:44
b8502f4 to
6eea710
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We have some large gaps in our thread start, resume, and pre-sampling traces that make it hard to tell where latency is coming from.
What Changed
Testing
cargo check -p codex-app-server -p codex-core -p codex-core-skills -p codex-core-plugins