[1 of 3] Support long raw TUI goal objectives#27508
Conversation
2aba824 to
d4f8529
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4f8529190
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bbc613c1dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a989259671
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2cfb435d0e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71637bace3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45e35b1147
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
One notable issue was raised by Codex, I don't think it's serious given most goal use cases will not be ran under such profiles:
|
Stack
Why
thread/goal/setlimits persisted objective text to 4000 characters. The TUI used to reject raw/goalobjectives above that limit, even though the client can make them usable by writing the long text to a file and storing a short objective that points at that file.This also needs to work for remote app-server sessions: filesystem API calls must create files on the app-server host, and the stored path must be meaningful to the agent on that host.
What Changed
fs/createDirectory,fs/writeFile,fs/readFile, andfs/removethat work for embedded and remote app-server sessions without changing the app-server protocol./goalobjectives into$CODEX_HOME/attachments/<uuid>/goal-objective.mdthrough the app-server filesystem APIs, then stores a short, readable objective that directs the agent to that file./goal edit. Other goal UI renders the readable stored objective normally, without managed-file-specific presentation logic.$CODEX_HOME, and cleans up newly materialized files when goal replacement or setting does not complete.Verification
/goalsubmission, large inline-paste expansion, queued oversized goals, app-facing materialization beforethread/goal/set, managed-path validation, editing, and cleanup.Manual Testing
$CODEX_HOMEdirectories. Oversized goals wrote only under the server home, and persisted references used the server-canonical path rather than the TUI path./goal editfor a managed objective and verified the full text was restored through remotefs/readFile.