lint: allow self-documenting builder arguments - #27507
Merged
Merged
Conversation
anp-oai
marked this pull request as ready for review
June 11, 2026 01:45
bolinfest
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builder-style setters often repeat the setting name in both the method and its sole argument. Calls such as
.enabled(false)are already self-documenting, so requiring/*enabled*/adds noise without clarifying the call.What changed
AGENTS.mdand the lint's own behavior documentation.Examples
Before this change we'd need redundant comments like this:
Now can be written like this:
Still disallowed:
Validation
Added UI coverage for boolean, numeric, and
Nonebuilder arguments, multi-argument methods, and explicit comment mismatches. Ranrustup run nightly-2025-09-18 cargo testintools/argument-comment-lint.