[codex] Remove async_trait from first-party code - #27475
Merged
Merged
Conversation
anp-oai
marked this pull request as ready for review
June 10, 2026 21:31
anp-oai
force-pushed
the
codex/remove-async-trait-or-cancel-ext
branch
2 times, most recently
from
June 10, 2026 22:31
040f405 to
8032d71
Compare
anp-oai
force-pushed
the
codex/remove-async-trait-or-cancel-ext
branch
from
June 11, 2026 18:32
8032d71 to
6234049
Compare
anp-oai
force-pushed
the
codex/remove-async-trait-or-cancel-ext
branch
from
June 11, 2026 18:47
6234049 to
933139a
Compare
bolinfest
approved these changes
Jun 11, 2026
bolinfest
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for getting this cleanup over the finish line!
anp-oai
force-pushed
the
codex/remove-async-trait-or-cancel-ext
branch
5 times, most recently
from
June 11, 2026 23:35
968c1a4 to
d97ca26
Compare
Use native async trait return types where possible and explicit boxed futures for object-safe traits. Remove all direct first-party async-trait dependencies.
anp-oai
force-pushed
the
codex/remove-async-trait-or-cancel-ext
branch
from
June 12, 2026 00:16
d97ca26 to
4df5f02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
First-party async traits should expose their
Sendcontracts explicitly without requiringasync_trait. This completes the migration pattern established in #27303 and #27304.What changed
async_traittraits with native return-positionimpl Future + Sendwhere statically dispatched and explicit boxedSendfutures where object safety is required.async-traitdependencies and the workspace dependency declaration.async-traitonly through the remaining transitive wrapper crates.randfrom 0.8.5 to 0.8.6 to resolve RUSTSEC-2026-0097 and keep the full cargo-deny check passing.Validation
just test -p codex-exec-server: 216 passed, 2 skipped.just test -p codex-model-provider: 39 passed.just test -p codex-coreandjust test: changed tests passed; remaining failures are environment-sensitive suites unrelated to this migration.cargo deny checkjust fixjust fmtcargo shearjust bazel-lock-check