[codex] Remove redundant plugin app auth state - #27465
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e0cb42464
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -111,7 +111,6 @@ pub struct AppSummary { | |||
| pub name: String, | |||
| pub description: Option<String>, | |||
| pub install_url: Option<String>, | |||
There was a problem hiding this comment.
Keep Python v2 models in sync with AppSummary
Removing needs_auth leaves generated Python v2 models requiring needsAuth, so plugin app responses fail to parse for Python clients. Check this app-server API break per guidance.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
python sdk has its own pipeline.
Summary
needsAuthfield fromAppSummaryand generated app-server schemasplugin/readfrom querying Apps MCP solely to hydrate unused connector auth stateplugin/install.appsNeedingAuthmembership andapp/list.isAccessibleas the authentication signalsWhy
Codex App and TUI do not consume
plugin/read.plugin.apps[].needsAuth. Hydrating it could establish an Apps MCP connection and discover tools on a coldplugin/readrequest, adding avoidable latency. The plugin APIs are still marked under development, so removing this wire field is preferable to retaining a misleading default.Verification
just write-app-server-schemajust fmtjust test -p codex-app-server-protocoljust test -p codex-app-server plugin_install_uses_remote_apps_needing_auth_responsejust test -p codex-app-server plugin_install_returns_apps_needing_authjust test -p codex-app-server plugin_read_returns_plugin_details_with_bundle_contentsjust test -p codex-tui plugin_detail_popup_snapshot_shows_install_actions_and_capability_summaries$xin-buildsimplify and debug reviews