Skip to content

[codex] Remove redundant plugin app auth state - #27465

Merged
xl-openai merged 1 commit into
mainfrom
xl/remove-plugin-app-needs-auth
Jun 11, 2026
Merged

[codex] Remove redundant plugin app auth state#27465
xl-openai merged 1 commit into
mainfrom
xl/remove-plugin-app-needs-auth

Conversation

@xl-openai

Copy link
Copy Markdown
Contributor

Summary

  • remove the redundant needsAuth field from AppSummary and generated app-server schemas
  • stop plugin/read from querying Apps MCP solely to hydrate unused connector auth state
  • preserve plugin/install.appsNeedingAuth membership and app/list.isAccessible as the authentication signals

Why

Codex App and TUI do not consume plugin/read.plugin.apps[].needsAuth. Hydrating it could establish an Apps MCP connection and discover tools on a cold plugin/read request, adding avoidable latency. The plugin APIs are still marked under development, so removing this wire field is preferable to retaining a misleading default.

Verification

  • just write-app-server-schema
  • just fmt
  • just test -p codex-app-server-protocol
  • just test -p codex-app-server plugin_install_uses_remote_apps_needing_auth_response
  • just test -p codex-app-server plugin_install_returns_apps_needing_auth
  • just test -p codex-app-server plugin_read_returns_plugin_details_with_bundle_contents
  • just test -p codex-tui plugin_detail_popup_snapshot_shows_install_actions_and_capability_summaries
  • $xin-build simplify and debug reviews

@xl-openai
xl-openai requested a review from xli-oai June 10, 2026 21:00
@xl-openai
xl-openai marked this pull request as ready for review June 10, 2026 21:00

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8e0cb42464

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -111,7 +111,6 @@ pub struct AppSummary {
pub name: String,
pub description: Option<String>,
pub install_url: Option<String>,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep Python v2 models in sync with AppSummary

Removing needs_auth leaves generated Python v2 models requiring needsAuth, so plugin app responses fail to parse for Python clients. Check this app-server API break per guidance.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python sdk has its own pipeline.

@xl-openai
xl-openai merged commit 1a9efd4 into main Jun 11, 2026
31 checks passed
@xl-openai
xl-openai deleted the xl/remove-plugin-app-needs-auth branch June 11, 2026 00:33
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants