Skip to content

[codex] Skip plugin MCP OAuth for matching app routes #27461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felixxia-oai merged 2 commits into from
Jun 15, 2026
Merged

[codex] Skip plugin MCP OAuth for matching app routes #27461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d5edd7
Skip plugin MCP OAuth when app route is available
felixxia-oai Jun 11, 2026
3c9aaf3
Update constructor name
felixxia-oai Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions codex-rs/app-server/src/request_processors/plugins.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1436,7 +1436,11 @@ impl PluginRequestProcessor {

self.on_effective_plugins_changed();

let plugin_mcp_servers = load_plugin_mcp_servers(result.installed_path.as_path()).await;
Comment thread
felixxia-oai marked this conversation as resolved.
let plugin_mcp_servers = load_plugin_mcp_servers(
result.installed_path.as_path(),
auth.as_ref().map(CodexAuth::auth_mode),
)
.await;
if !plugin_mcp_servers.is_empty() {
self.start_plugin_mcp_oauth_logins(&config, plugin_mcp_servers)
.await;
Expand All @@ -1445,7 +1449,6 @@ impl PluginRequestProcessor {
let plugin_app_declarations = load_plugin_apps(result.installed_path.as_path()).await;
let plugin_apps =
codex_plugin::app_connector_ids_from_declarations(&plugin_app_declarations);
let auth = self.auth_manager.auth().await;
let apps_needing_auth = self
.plugin_apps_needing_auth_for_install(
&config,
Expand Down Expand Up @@ -1554,7 +1557,11 @@ impl PluginRequestProcessor {
self.analytics_events_client
.track_plugin_installed(plugin_metadata);

let plugin_mcp_servers = load_plugin_mcp_servers(result.installed_path.as_path()).await;
let plugin_mcp_servers = load_plugin_mcp_servers(
result.installed_path.as_path(),
auth.as_ref().map(CodexAuth::auth_mode),
)
.await;
if !plugin_mcp_servers.is_empty() {
self.start_plugin_mcp_oauth_logins(&config, plugin_mcp_servers)
.await;
Expand Down
Loading
Loading