feat(app-server): persist remote-control desired state by apanasenko-oai · Pull Request #27445 · openai/codex

apanasenko-oai · 2026-06-10T19:26:52Z

Why

Remote-control runtime enablement and persisted enrollment preference were represented by separate flags. That made startup rehydration, RPC persistence, and new-enrollment seeding race with one another, and it did not cleanly distinguish runtime-only CLI or daemon starts from durable app-server RPC changes.

What Changed

Replace the parallel enablement, seed, and rehydration flags with one transport-owned RemoteControlDesiredState.
Add nullable enrollment-scoped persistence and preserve existing preferences during enrollment upserts.
Rehydrate plain startup only after auth and client scope resolve, without overwriting a concurrent RPC transition.
Make ordinary remoteControl/enable and remoteControl/disable durable while retaining ephemeral: true for runtime-only callers.
Have the daemon explicitly request ephemeral enablement and regenerate the app-server schemas.

Verification

Covered migration and NULL/0/1 persistence round trips.
Covered plain-start rehydration and runtime-only versus durable enrollment seeding.
Covered durable enable, durable disable, and ephemeral enable through app-server RPC.
Covered the daemon's exact { "ephemeral": true } request payload.

Related issue: N/A (internal remote-control persistence architecture change).

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c1c83d3db1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ccf773428

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 89e994bf64

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

This reverts commit 89e994b.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 751a2a5ffa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 51c0ede502

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38fa3a8ac4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

apanasenko-oai · 2026-06-11T18:48:23Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38fa3a8ac4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4c46df25f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

apanasenko-oai · 2026-06-12T04:04:20Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e34ec27895

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Persist remote-control desired state

c1c83d3

apanasenko-oai changed the title ~~Persist remote-control desired state~~ feat(app-server): persist remote-control desired state Jun 10, 2026

apanasenko-oai marked this pull request as ready for review June 10, 2026 19:29

chatgpt-codex-connector Bot reviewed Jun 10, 2026

View reviewed changes

Comment thread codex-rs/app-server-transport/src/transport/remote_control/mod.rs Outdated

Comment thread codex-rs/app-server-transport/src/transport/remote_control/mod.rs

apanasenko-oai added 2 commits June 10, 2026 15:24

Complete durable remote-control enrollment on enable

11b7a31

codex: fix CI failure on PR #27445

37c9a1a

owenlin0 reviewed Jun 11, 2026

View reviewed changes

Comment thread codex-rs/app-server-transport/src/transport/remote_control/mod.rs

codex: address PR review feedback (#27445)

2ccf773

owenlin0 reviewed Jun 11, 2026

View reviewed changes

Comment thread codex-rs/app-server-protocol/src/protocol/common.rs

chatgpt-codex-connector Bot reviewed Jun 11, 2026

View reviewed changes

Comment thread codex-rs/app-server-transport/src/transport/remote_control/websocket.rs Outdated

codex: address PR review feedback (#27445)

89e994b

chatgpt-codex-connector Bot reviewed Jun 11, 2026

View reviewed changes

Comment thread codex-rs/app-server-protocol/src/protocol/common.rs Outdated

Comment thread codex-rs/app-server-daemon/src/remote_control_client.rs Outdated

Comment thread codex-rs/app-server-transport/src/transport/remote_control/mod.rs Outdated

owenlin0 approved these changes Jun 11, 2026

View reviewed changes

apanasenko-oai added 3 commits June 11, 2026 09:38

Revert "codex: address PR review feedback (#27445)"

f06ad42

This reverts commit 89e994b.

codex: address PR review feedback (#27445)

751a2a5

codex: fix argument comment lint on PR #27445

5d46286

chatgpt-codex-connector Bot reviewed Jun 11, 2026

View reviewed changes

apanasenko-oai added 2 commits June 11, 2026 10:54

codex: address PR review feedback (#27445)

51201c3

codex: address PR review feedback (#27445)

51c0ede

chatgpt-codex-connector Bot reviewed Jun 11, 2026

View reviewed changes

Comment thread codex-rs/app-server-transport/src/transport/remote_control/websocket.rs

Comment thread codex-rs/app-server-transport/src/transport/remote_control/mod.rs

apanasenko-oai added 2 commits June 11, 2026 11:16

codex: fix Windows clippy on PR #27445

5957b62

codex: address PR review feedback (#27445)

38fa3a8

chatgpt-codex-connector Bot reviewed Jun 11, 2026

View reviewed changes

Comment thread codex-rs/state/src/runtime/remote_control.rs

chatgpt-codex-connector Bot reviewed Jun 11, 2026

View reviewed changes

Comment thread codex-rs/app-server/src/lib.rs Outdated

Comment thread codex-rs/app-server-transport/src/transport/remote_control/tests.rs

Comment thread codex-rs/app-server/src/message_processor.rs

Comment thread codex-rs/app-server-daemon/src/lib.rs Outdated

codex: simplify remote control startup state

6d519c7

apanasenko-oai added the code-reviewed label Jun 11, 2026

apanasenko-oai added 2 commits June 11, 2026 14:50

codex: simplify remote control availability state

ffc649d

fix remote control startup edge cases

d4c46df

chatgpt-codex-connector Bot reviewed Jun 11, 2026

View reviewed changes

Comment thread codex-rs/app-server/src/lib.rs Outdated

reject disabled transportless remote control startup

e34ec27

chatgpt-codex-connector Bot reviewed Jun 12, 2026

View reviewed changes

Comment thread codex-rs/app-server/src/message_processor.rs

Comment thread codex-rs/app-server-transport/src/transport/remote_control/mod.rs

apanasenko-oai merged commit d61dfeb into main Jun 12, 2026
31 checks passed

apanasenko-oai deleted the codex/remote-control-desired-state-persistence branch June 12, 2026 04:28

github-actions Bot locked and limited conversation to collaborators Jun 12, 2026

Uh oh!

Conversation

apanasenko-oai commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

What Changed

Verification

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

apanasenko-oai commented Jun 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

apanasenko-oai commented Jun 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

apanasenko-oai commented Jun 10, 2026 •

edited

Loading