Skip to content

[codex] Propagate plugin app categories - #27420

Merged
charlesgong-openai merged 1 commit into
mainfrom
dev/charlesgong/plugin-app-category-protocol
Jun 11, 2026
Merged

[codex] Propagate plugin app categories#27420
charlesgong-openai merged 1 commit into
mainfrom
dev/charlesgong/plugin-app-category-protocol

Conversation

@charlesgong-openai

@charlesgong-openai charlesgong-openai commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

What

  • Parse optional .app.json category overrides for plugin apps.
  • Add nullable category to AppSummary and AppTemplateSummary in the app-server protocol.
  • Fall back from branding.category to the first non-empty app_metadata.categories value when building app/template summaries.
  • Regenerate schema/type fixtures and update plugin read/install tests.

Why

The plugin details UI needs a normalized per-app category. Some apps only provide their default category in metadata, while others need a local .app.json override.

@charlesgong-openai
charlesgong-openai force-pushed the dev/charlesgong/plugin-app-category-protocol branch 2 times, most recently from 52bc56c to 3291038 Compare June 11, 2026 16:42
@charlesgong-openai
charlesgong-openai marked this pull request as ready for review June 11, 2026 16:49

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 32910385c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/app-server/src/request_processors/plugins.rs Outdated
Comment thread codex-rs/core-plugins/src/loader.rs
@charlesgong-openai
charlesgong-openai force-pushed the dev/charlesgong/plugin-app-category-protocol branch from 3291038 to 439b27a Compare June 11, 2026 17:03
@charlesgong-openai
charlesgong-openai force-pushed the dev/charlesgong/plugin-app-category-protocol branch from 439b27a to 2f6191e Compare June 11, 2026 17:11
@charlesgong-openai
charlesgong-openai merged commit eb76336 into main Jun 11, 2026
31 checks passed
@charlesgong-openai
charlesgong-openai deleted the dev/charlesgong/plugin-app-category-protocol branch June 11, 2026 17:34
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants