[codex-analytics] emit internally started turn events - #27392
Merged
marksteinbrick-oai merged 1 commit intoJun 10, 2026
Conversation
marksteinbrick-oai
marked this pull request as ready for review
June 10, 2026 21:57
rhan-oai
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Currently, the analytics reducer omits
codex_turn_eventfor internally started subagent turnsTurnState.connection_idto select app-server client and runtime metadataturn/startsets this field for client-started turns, while internal subagent turns bypass that pathWhat Changed
TurnState.connection_idauthoritative for client-started turnsVerification
just test -p codex-analytics(71 tests passed)just fix -p codex-analyticsjust fmt