Remove async-trait from extension contributors - #27383
Merged
Merged
Conversation
jif-oai
marked this pull request as ready for review
June 10, 2026 12:05
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Extension contributors are registered behind
dyn Traitobjects, so nativeasync fn/RPITIT methods would make these traits non-object-safe. Spell out the boxed,Sendfuture contract directly soextension-apino longer needsasync-traitwhile retaining the existing runtime model.What changed
ExtensionFuturealias and use it for asynchronous contributor methodsBox::pin(async move { ... })async-traitdependencies where they are no longer used, keeping it dev-only where unrelated test executors still require itBehavior
No behavior change is intended. Contributor futures remain boxed,
Send, dynamically dispatched, and lazily executed; cancellation and callback ordering stay unchanged.Testing
just test -p codex-extension-api(11 passed)codex-corecontributor tests (14 passed)just fmtjust bazel-lock-updatejust bazel-lock-checkA broad local
codex-corerun compiled successfully but encountered unrelated sandbox and missing test-binary fixture failures; CI will run the full checks.