Guard core test subprocess cleanup - #27343
Merged
Merged
Conversation
etraut-openai
marked this pull request as ready for review
June 10, 2026 08:00
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52a69d375c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| } | ||
|
|
||
| fn run_cli_command(command: &mut Command) -> io::Result<Output> { |
Contributor
There was a problem hiding this comment.
Let's Add a comment with context so Codex use it when making new tests
Contributor
Author
There was a problem hiding this comment.
Yep, good call. Added.
aibrahim-oai
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Local integration-heavy
codex-coreCLI tests can time out or be interrupted after spawningcodex exec. Stopping only the direct child is not enough:codex execcan leave grandchildren behind, includingpython3/python3.12processes that get reparented to PID 1 and keep running after the test is gone.This PR fixes that failure mode directly for the affected CLI integration tests, without changing production code or reducing local test concurrency.
What
cli_streamcodex execsubprocesses through a small private wrapper incore/tests/suite/cli_stream.rs..output()-style stdout/stderr capture and the existing 30-second timeout behavior.The switch from
assert_cmd::Commandtostd::process::Commandis only for these subprocess launches;assert_cmddoes not expose a pre-spawn hook for setting the process group.Verification
just test -p codex-core --test all responses_mode_stream_cliThis is limited to core integration tests; it does not change production
srccode paths.