Skip to content

[codex] Move release platform rules into bazel package - #27321

Merged
anp-oai merged 1 commit into
mainfrom
codex/release-rbe-01-platform-rules
Jun 10, 2026
Merged

[codex] Move release platform rules into bazel package#27321
anp-oai merged 1 commit into
mainfrom
codex/release-rbe-01-platform-rules

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Intent

Keep release-specific Bazel helpers out of the shared Rust crate definitions and colocate them with Bazel platform configuration.

Implementation

Moves multiplatform_binaries and its platform list from defs.bzl into bazel/platforms/release_binaries.bzl and updates the CLI load site. Behavior is unchanged.

Validation

  • bazel query //codex-rs/cli:release_binaries

Stack: 1 of 6.

@anp-oai
anp-oai marked this pull request as ready for review June 10, 2026 15:56
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

💡 Codex Review

# Release platform rules live in this package.

P3 Badge Keep generated build outputs ignored

Adding this tracked package under build/ by removing the broad ignore makes every other generated tree under /build visible to Git. In workflows that materialize paths the repo already references, such as build/linux/debian_bullseye_amd64-sysroot, git status will be flooded and those generated artifacts can be committed accidentally; keep /build/* ignored and add a narrow exception for /build/platforms/ instead.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bazel/platforms/release_binaries.bzl
@anp-oai
anp-oai force-pushed the codex/release-rbe-01-platform-rules branch from 730289b to c90706e Compare June 10, 2026 19:38
@anp-oai anp-oai changed the title [codex] Move release platform rules into build package [codex] Move release platform rules into bazel package Jun 10, 2026
@anp-oai
anp-oai enabled auto-merge (squash) June 10, 2026 19:39
@anp-oai
anp-oai merged commit 1deae7b into main Jun 10, 2026
31 checks passed
@anp-oai
anp-oai deleted the codex/release-rbe-01-platform-rules branch June 10, 2026 19:45
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants