Forward standalone assistant output to realtime by guinness-oai · Pull Request #27319 · openai/codex

guinness-oai · 2026-06-10T05:46:25Z

Why

When a realtime session is open without an active frontend-model handoff, completed Codex assistant messages are currently dropped. That prevents the frontend model from hearing orchestrator preambles and final responses produced by typed turns or other non-handoff work, which makes the two models present as disconnected personas.

Active handoffs already forward each completed assistant message, including preambles. This change leaves those V1 and V2 paths intact and fills only the no-active-handoff gap.

What changed

Send standalone V1 assistant messages through conversation.handoff.append with a stable synthetic handoff ID
Send standalone V2 assistant messages as normal [BACKEND] conversation.item.create message items, then enqueue response.create so the frontend model responds
Preserve the existing active V1 and V2 transport and completion behavior
Continue excluding user messages from realtime mirroring
Skip empty output and cap each complete context injection, including its V2 prefix, at 1,000 tokens
Add end-to-end coverage for both wire formats, V2 response creation, preambles, final responses, and truncation

Test plan

CI

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 772f20c61b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

guinness-oai · 2026-06-10T05:53:00Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b5290d3a05

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

guinness-oai · 2026-06-10T06:17:34Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6db81257cd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-10T06:23:28Z

+                output_text: truncate_realtime_text_to_token_budget(
+                    &output_text,
+                    REALTIME_ASSISTANT_OUTPUT_TOKEN_BUDGET,
+                ),


Enforce the >1k context review threshold

Standalone output without active handoff is fed back into realtime model context, but this 1,000-token budget uses the byte/4 estimator. For CJK/emoji or tokenizer-dense text it can still exceed the >1k-token manual-review threshold; use a stricter cap before forwarding. guidance

Useful? React with 👍 / 👎.

hmm is this actually p0?

aibrahim-oai · 2026-06-10T17:45:55Z

-        if self.conversation.running_state().await.is_none()
-            || self.conversation.active_handoff_id().await.is_none()
-        {
+        if self.conversation.running_state().await.is_none() {


I am curious why not just removing || self.conversation.active_handoff_id().await.is_none()? why changes in codex-rs/codex-api/src/endpoint/realtime_websocket/methods.rs and codex-rs/core/src/realtime_conversation.rs

Removing that condition is necessary, but not sufficient: handoff_out() also returns early without an active handoff. More importantly, the existing downstream path assumes a real handoff ID. V1 would otherwise emit a function-call output without a corresponding call, while V2 would drop the progress update and never request a response.

The realtime_conversation.rs changes add explicit standalone behavior: V1 sends conversation.handoff.append; V2 sends a normal message item plus response.create. The methods.rs change only exposes the existing V1 protocol event through RealtimeWebsocketWriter. The remaining bulk is E2E coverage for both contracts.

aibrahim-oai

approving to unblock. Let's add a todo to clean up

guinness-oai · 2026-06-10T21:25:23Z

/merge

guinness-oai requested a review from a team as a code owner June 10, 2026 05:46

chatgpt-codex-connector Bot reviewed Jun 10, 2026

View reviewed changes

Comment thread codex-rs/core/src/realtime_conversation.rs Outdated

Comment thread codex-rs/core/src/realtime_conversation.rs Outdated

guinness-oai force-pushed the guinness/realtime-handoff-append-minimal branch from 772f20c to b5290d3 Compare June 10, 2026 05:52

chatgpt-codex-connector Bot reviewed Jun 10, 2026

View reviewed changes

Comment thread codex-rs/core/src/realtime_conversation.rs Outdated

guinness-oai force-pushed the guinness/realtime-handoff-append-minimal branch 2 times, most recently from e74db69 to 6db8125 Compare June 10, 2026 06:16

chatgpt-codex-connector Bot reviewed Jun 10, 2026

View reviewed changes

guinness-oai force-pushed the guinness/realtime-handoff-append-minimal branch 3 times, most recently from 7c2165b to 7afe0da Compare June 10, 2026 07:06

Forward standalone assistant output to realtime

f5d7eac

guinness-oai force-pushed the guinness/realtime-handoff-append-minimal branch from 7afe0da to f5d7eac Compare June 10, 2026 07:13

aibrahim-oai reviewed Jun 10, 2026

View reviewed changes

aibrahim-oai approved these changes Jun 10, 2026

View reviewed changes

Add TODO for standalone handoff event

942e9da

guinness-oai enabled auto-merge (squash) June 10, 2026 21:25

guinness-oai merged commit 22dd6eb into main Jun 10, 2026
54 of 55 checks passed

guinness-oai deleted the guinness/realtime-handoff-append-minimal branch June 10, 2026 21:32

github-actions Bot locked and limited conversation to collaborators Jun 10, 2026

Uh oh!

Conversation

guinness-oai commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

What changed

Test plan

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

guinness-oai commented Jun 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

guinness-oai commented Jun 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

guinness-oai Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aibrahim-oai Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

guinness-oai Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

aibrahim-oai left a comment

Choose a reason for hiding this comment

Uh oh!

guinness-oai commented Jun 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

guinness-oai commented Jun 10, 2026 •

edited

Loading