[codex] Move persistence policy application into ThreadStore - #27318
Merged
Conversation
wiltzius-openai
commented
Jun 10, 2026
| .or_else(|| self.turns.last().cloned()) | ||
| } | ||
|
|
||
| pub fn turn_snapshot(&self, turn_id: &str) -> Option<Turn> { |
Contributor
Author
There was a problem hiding this comment.
this isn't directly used in this PR, but is a little helper method to grab turn info by ID; some projectors need to be able to look up turn info by ID
wiltzius-openai
force-pushed
the
wiltzius/codex/thread-history-clean-room
branch
3 times, most recently
from
June 10, 2026 22:06
c396755 to
9ffdfd6
Compare
wiltzius-openai
commented
Jun 10, 2026
wiltzius-openai
force-pushed
the
wiltzius/codex/thread-history-clean-room
branch
from
June 10, 2026 22:44
9ffdfd6 to
eafa1fc
Compare
wiltzius-openai
marked this pull request as ready for review
June 10, 2026 22:45
pakrym-oai
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the application of the persistence policy into the thread store, so thread stores can get raw append items rather than canonical append items. This will enable store-specific projections over the raw input items.