[codex] Fix post-merge analytics integration failures - #27285
Merged
Conversation
anp-oai
marked this pull request as ready for review
June 10, 2026 02:44
aibrahim-oai
approved these changes
Jun 10, 2026
anp-oai
enabled auto-merge (squash)
June 10, 2026 02:49
anp-oai
disabled auto-merge
June 10, 2026 03:13
marksteinbrick-oai
approved these changes
Jun 10, 2026
anp-oai
force-pushed
the
codex/fix-goal-analytics-thread-source-clone
branch
from
June 10, 2026 03:29
9f2ae94 to
ea56e21
Compare
This reverts commit ea56e21.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Recent merges left
mainwith analytics integration build failures. Local Cargo runs also made the trimmed-skills test depend on developer-installed skills, while Bazel used an isolated home.What changed
thread_metadata.thread_sourcewhen constructing goal analytics event parameters.ThreadExtensionDependencies.Validation
cargo check -p codex-analyticsjust test -p codex-analytics(71 tests)just test -p codex-app-server(837 tests; one unrelated zsh-fork timeout passed on retry)